This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($animateCss): add missing doc #13082
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| @@ -186,6 +186,8 @@ var ANIMATE_TIMER_KEY = '$$animateCss'; | |||
| * | |||
| * * `event` - The DOM event (e.g. enter, leave, move). When used, a generated CSS class of `ng-EVENT` and `ng-EVENT-active` will be applied | |||
| * to the element during the animation. Multiple events can be provided when spaces are used as a separator. (Note that this will not perform any DOM operation.) | |||
| * * `structural` - Indicates that the `ng-` prefix will be added to the event class. Setting `false` or omitting wil turn `ng-EVENT` and | |||
There was a problem hiding this comment.
Setting false --> Setting to false
wil --> will
|
@googlebot I signed it! |
|
CLAs look good, thanks! |
|
Good work. Would you mind squashing everything into one commit and then rebasing on master? |
|
I will try, as soon as i understand how to do it ;) |
Add missing documentation for structural option in animateCss service close angular#13049
|
After some headache I think I'va made it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13049